third_party/libphonenumber/README.chromium - Issue 6803005: Autofill phone number enhancements and integration of Phone Number Util Library: part 1

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libphonenumber/README.chromium

Issue 6803005: Autofill phone number enhancements and integration of Phone Number Util Library: part 1 (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 Name: International Phone Number Library

	2 Short Name: libphonenumber

	3 URL: http://libphonenumber.googlecode.com/svn/trunk/

	4 Version: unknown

	5 Revision: r170

	6 Security Critical: yes

	7

	8 integration owner: georgey@chromium.org
	dhollowa 2011/04/26 17:26:14 I don't see "integration owner" in other README.ch I don't see "integration owner" in other README.chromium files. Is there a reason you added it? GeorgeY 2011/04/27 00:41:45 Removed - now we have OWNERS file Show quoted text On 2011/04/26 17:26:14, dhollowa wrote: > I don't see "integration owner" in other README.chromium files. Is there a > reason you added it? Removed - now we have OWNERS file
	9

	10 This directory contains the source code of international phone number library

	11 for C/C++
	dhollowa 2011/04/26 17:26:14 Nit: period at the end of the sentence please. Nit: period at the end of the sentence please. GeorgeY 2011/04/27 00:41:45 Done. Show quoted text On 2011/04/26 17:26:14, dhollowa wrote: > Nit: period at the end of the sentence please. Done.
	12

	13 This library depends on

	14 1. base\ for types, scoped_ptr's, etc.
	dhollowa 2011/04/26 17:26:14 nit: Use forward slashes: "base/" to match url and nit: Use forward slashes: "base/" to match url and cpp-include style. (And below). GeorgeY 2011/04/27 00:41:45 Done. Show quoted text On 2011/04/26 17:26:14, dhollowa wrote: > nit: Use forward slashes: "base/" to match url and cpp-include style. (And > below). Done.
	15 2. third_party\icu for internationalisation, UTF8-16-32 conversion and regular

	16 expressions.

	17 3. third_party\protobuf Lite version.

	18

	19 Additional files, not in the original library:

	20 libphonenumber.gyp

	21 README.chromium

	22 chrome\regexp_adapter_icuregexp.cc

	23

	24

OLD	NEW

« build/all.gyp ('K') | « chrome/chrome_browser.gypi ('k') | third_party/libphonenumber/chrome/regexp_adapter_icuregexp.cc » ('j') | third_party/libphonenumber/libphonenumber.gyp » ('J')