Issue 6802023: Add nacl_modules key to extension manifests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6802023: Add nacl_modules key to extension manifests (Closed)

Created:
9 years, 8 months ago by abarth-chromium

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman, commit-bot: I haz the power, aa

CC:
chromium-reviews, Erik does not do reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add nacl_modules key to extension manifests This is an experimental extension feature to let extensions register NaCl modules as a handler for MIME types. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80888

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 1

Patch Set 6 : '' #

Patch Set 7 : '' #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -24 lines)			Patch
M	chrome/common/extensions/extension.h	View	1 2	3 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1 2 3 4 5	15 chunks	+63 lines, -24 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.h	View	1 2 3 4 5 6	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.cc	View	1 2 3 4 5 6	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

lgtm http://codereview.chromium.org/6802023/diff/2006/chrome/common/extensions/extension.cc File chrome/common/extensions/extension.cc (right): http://codereview.chromium.org/6802023/diff/2006/chrome/common/extensions/extension.cc#newcode1740 chrome/common/extensions/extension.cc:1740: ListValue* list_value; nit: initialize primitives

9 years, 8 months ago (2011-04-08 00:07:37 UTC) #2

Change committed as 80888

Expand Messages | Collapse Messages