Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 6802021: Add support to put a patchset into a subdirectory. (Closed)

Created:
9 years, 8 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Visibility:
Public.

Description

Add support to put a patchset into a subdirectory. Add better code to handle diff header, especially add more patch verification code. Add a lot of tests. Add mangling of \ to /. R=dpranke@chromium.org BUG=78561 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81017

Patch Set 1 #

Patch Set 2 : fixed and more tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+400 lines, -111 lines) Patch
M patch.py View 1 5 chunks +184 lines, -88 lines 0 comments Download
M tests/patch_test.py View 1 4 chunks +216 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
9 years, 8 months ago (2011-04-06 20:14:16 UTC) #1
Dirk Pranke
Looks more-or-less fine. I assume that there's a separate patch that actually makes use of ...
9 years, 8 months ago (2011-04-07 02:10:53 UTC) #2
M-A Ruel
I had forgot to put the bug number. http://code.google.com/p/chromium/issues/detail?id=78561 will give more context.
9 years, 8 months ago (2011-04-07 14:06:47 UTC) #3
M-A Ruel
But the patch is probably wrong as-is. I'll ping you once I've done with the ...
9 years, 8 months ago (2011-04-07 14:07:59 UTC) #4
M-A Ruel
Sent the commit queue part for review at http://codereview.chromium.org/6813044/ and I indeed needed to rework ...
9 years, 8 months ago (2011-04-08 16:58:59 UTC) #5
Dirk Pranke
9 years, 8 months ago (2011-04-08 21:49:27 UTC) #6
LGTM. This is something of a rubber-stamp, since I'm not an expert on patch
formats, but it looks pretty good.

Powered by Google App Engine
This is Rietveld 408576698