src/codegen-ia32.cc - Issue 6802: DeclareContextSlot took an extra completely random argument from the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codegen-ia32.cc

Issue 6802: DeclareContextSlot took an extra completely random argument from the... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 12 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/codegen-ia32.cc

===================================================================

--- src/codegen-ia32.cc (revision 446)

+++ src/codegen-ia32.cc (working copy)

@@ -1735,11 +1735,8 @@

} else {

__ push(Immediate(0)); // no initial value!

}

- __ CallRuntime(Runtime::kDeclareContextSlot, 5);

- // DeclareContextSlot pops the assigned value by accepting an

- // extra argument and returning the TOS; no need to explicitly

- // pop here.

- __ push(eax);

+ __ CallRuntime(Runtime::kDeclareContextSlot, 4);

+ // Ignore the return value (declarations are statements).

return;

}

« no previous file with comments | « src/codegen-arm.cc ('k') | src/runtime.h » ('j') | no next file with comments »