Issue 6801052: Fix classification of a history.back() that interrupts a pending navigation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6801052: Fix classification of a history.back() that interrupts a pending navigation. (Closed)

Created:
9 years, 8 months ago by Charlie Reis

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix classification of a history.back() that interrupts a pending navigation. BUG=78031 TEST=NavigationControllerTest.LoadURL_BackPreemptsPending Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80941

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -3 lines)			Patch
	M	content/browser/tab_contents/navigation_controller.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download
	M	content/browser/tab_contents/navigation_controller_unittest.cc	View		1 chunk	+39 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Charlie Reis

This ensures the existing entry matches the current page before we try to classify it ...

9 years, 8 months ago (2011-04-07 17:30:30 UTC) #1

LGTM