Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 6801045: remove quiet and loglevel=1 from arm cmdline for now (Closed)

Created:
9 years, 8 months ago by Olof Johansson
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

remove quiet and loglevel=1 from arm cmdline for now It makes debugging system boot issues harder, so let's re-enable console output for a while. It will be quieted down again later. Change-Id: I7c543c09818c0152470c9f5e54d36c614d05bf3a BUG=chrome-os-partner:3199 TEST=Boot a system, check for console output before login screen Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=24e10cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M build_kernel_image.sh View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Olof Johansson
9 years, 8 months ago (2011-04-07 14:06:50 UTC) #1
Mandeep Singh Baines
9 years, 8 months ago (2011-04-07 20:30:29 UTC) #2
LGTM

olofj@chromium.org (olofj@chromium.org) wrote:
> Reviewers: Mandeep Singh Baines,
> 
> Description:
> remove quiet and loglevel=1 from arm cmdline for now
> 
> It makes debugging system boot issues harder, so let's re-enable console
> output for a while. It will be quieted down again later.
> 
> Change-Id: I7c543c09818c0152470c9f5e54d36c614d05bf3a
> 
> BUG=chrome-os-partner:3199
> TEST=Boot a system, check for console output before login screen
> 
> 
> Please review this at http://codereview.chromium.org/6801045/
> 
> SVN Base: ssh://gitrw.chromium.org:9222/crosutils.git@master
> 
> Affected files:
>   M build_kernel_image.sh
> 
> 
> Index: build_kernel_image.sh
> diff --git a/build_kernel_image.sh b/build_kernel_image.sh
> index
5ee3e305a322d0fffade0088d204273757b9894a..59e37b48b3e9d8c988f0b605e2cbb734e0577ed7
> 100755
> --- a/build_kernel_image.sh
> +++ b/build_kernel_image.sh
> @@ -135,8 +135,6 @@ fi
> 
>  cat <<EOF > "${FLAGS_working_dir}/boot.config"
>  root=${FLAGS_root}
> -quiet
> -loglevel=1
>  rootwait
>  ro
>  dm_verity.error_behavior=${FLAGS_verity_error_behavior}
> @@ -156,6 +154,8 @@ if [[ "${FLAGS_arch}" = "x86" ]]; then
>    # FIXME: remove serial output, debugging messages.
>    cat <<EOF | cat - "${FLAGS_working_dir}/boot.config" \
>      > "${FLAGS_working_dir}/config.txt"
> +quiet
> +loglevel=1
>  console=tty2
>  init=/sbin/init
>  add_efi_memmap
> @@ -176,7 +176,10 @@ EOF
> 
>    sign_the_kernel=${FLAGS_TRUE}
>  elif [[ "${FLAGS_arch}" = "arm" ]]; then
> -  cp "${FLAGS_working_dir}/boot.config" "${FLAGS_working_dir}/config.txt"
> +  cat <<EOF | cat - "${FLAGS_working_dir}/boot.config" \
> +    > "${FLAGS_working_dir}/config.txt"
> +earlyprintk
> +EOF
>    WORK="${WORK} ${FLAGS_working_dir}/config.txt"
> 
>    kernel_script="${FLAGS_working_dir}/kernel.scr"
> 
> 

Powered by Google App Engine
This is Rietveld 408576698