Issue 6801043: autotest/factory_Finalize: support wipe_method in finalization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6801043: autotest/factory_Finalize: support wipe_method in finalization (Closed)

Created:
9 years, 8 months ago by Hung-Te

Modified:
9 years, 7 months ago

Reviewers:
Tom Wai-Hong Tam

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli

Base URL:
ssh://gitrw.chromium.org:9222/autotest.git@master

Visibility:
Public.

Description

autotest/factory_Finalize: support wipe_method in finalization This is a continue of http://codereview.chromium.org/6812015, to support wipe method in autotest UI framework BUG=chrome-os-partner:2594 TEST=run factory_Finalize with secure_wipe=True # seeing --wipe_method='secure' run with secure_wipe=False # seeing --wipe_method='fast' Change-Id: I4e9caa1615cecd4cb1c21184ef599579bad4f2c3 R=waihong@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3a3a504

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove extra space #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	client/site_tests/factory_Finalize/factory_Finalize.py	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Tom Wai-Hong Tam

LGTM with a nit. http://codereview.chromium.org/6801043/diff/1/client/site_tests/factory_Finalize/factory_Finalize.py File client/site_tests/factory_Finalize/factory_Finalize.py (right): http://codereview.chromium.org/6801043/diff/1/client/site_tests/factory_Finalize/factory_Finalize.py#newcode111 client/site_tests/factory_Finalize/factory_Finalize.py:111: '--wipe_method "%s"' % ('secure' if ...

9 years, 8 months ago (2011-04-08 00:55:10 UTC) #2

Hung-Te

9 years, 8 months ago (2011-04-08 01:06:12 UTC) #3

http://codereview.chromium.org/6801043/diff/1/client/site_tests/factory_Final...
File client/site_tests/factory_Finalize/factory_Finalize.py (right):

http://codereview.chromium.org/6801043/diff/1/client/site_tests/factory_Final...
client/site_tests/factory_Finalize/factory_Finalize.py:111: '--wipe_method "%s"'
% ('secure' if secure_wipe  else 'fast'),
On 2011/04/08 00:55:10, Tom Wai-Hong Tam wrote:
> Should leave one space between "secure_wipe" and "else".

Done.

Expand Messages | Collapse Messages