Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 6801040: Fix bad deoptimization tests for double-to-int conversion. (Closed)

Created:
9 years, 8 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Fix bad deoptimization tests for double-to-int conversion. Deopted on zero result, not just bad cvttsi2sd conversion. Add inline floating point result for SHR in Smi TypeRecordingBinaryOpStub. Small optimizations. Adding rightshift to case handled by floating point result in type-recording binary op stub. Committed: http://code.google.com/p/v8/source/detail?r=7537

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -29 lines) Patch
M src/x64/code-stubs-x64.cc View 4 chunks +35 lines, -27 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
9 years, 8 months ago (2011-04-07 09:39:28 UTC) #1
William Hesse
9 years, 8 months ago (2011-04-07 10:42:22 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698