Issue 6801017: Changes 'Open all' bookmarks to not recurse through nested folders.

Issue 6801017: Changes 'Open all' bookmarks to not recurse through nested folders. (Closed)

Created:
9 years, 8 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Changes 'Open all' bookmarks to not recurse through nested folders. BUG=20781 TEST=see bug R=arv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80787

Patch Set 2 : Update hasBookmarks #

Total comments: 1

Patch Set 3 : Remove tree_iterator #

Patch Set 4 : i++ #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -217 lines)			Patch
D	chrome/browser/resources/bookmark_manager/js/bmm/tree_iterator.js	View	1 2	1 chunk	+0 lines, -113 lines	0 comments	Download
D	chrome/browser/resources/bookmark_manager/js/bmm/tree_iterator_test.html	View	1 2	1 chunk	+0 lines, -94 lines	0 comments	Download
M	chrome/browser/resources/bookmark_manager/main.html	View	1 2 3	3 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

http://codereview.chromium.org/6801017/diff/1/chrome/browser/resources/bookmark_manager/main.html File chrome/browser/resources/bookmark_manager/main.html (right): http://codereview.chromium.org/6801017/diff/1/chrome/browser/resources/bookmark_manager/main.html#newcode1074 chrome/browser/resources/bookmark_manager/main.html:1074: var it = new bmm.TreeIterator(node); This one needs to ...

9 years, 8 months ago (2011-04-06 19:22:38 UTC) #2

sky

On 2011/04/06 19:22:38, arv wrote: > http://codereview.chromium.org/6801017/diff/1/chrome/browser/resources/bookmark_manager/main.html > File chrome/browser/resources/bookmark_manager/main.html (right): > > http://codereview.chromium.org/6801017/diff/1/chrome/browser/resources/bookmark_manager/main.html#newcode1074 > ...

9 years, 8 months ago (2011-04-06 20:55:50 UTC) #3

arv (Not doing code reviews)

Can you remove the tree_iterator.js file too? http://codereview.chromium.org/6801017/diff/3001/chrome/browser/resources/bookmark_manager/main.html File chrome/browser/resources/bookmark_manager/main.html (right): http://codereview.chromium.org/6801017/diff/3001/chrome/browser/resources/bookmark_manager/main.html#newcode1074 chrome/browser/resources/bookmark_manager/main.html:1074: for (var ...

9 years, 8 months ago (2011-04-06 21:34:24 UTC) #4

arv (Not doing code reviews)

Please update chrome_extra_resources.target.mk too http://www.google.com/codesearch?vert=chromium&q=tree_iterator%5C.js

9 years, 8 months ago (2011-04-06 22:16:54 UTC) #6

LGTM

Expand Messages | Collapse Messages