Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 6800028: Verify that sync updates_received is 0 on browser restart (Closed)

Created:
9 years, 8 months ago by Raghu Simha
Modified:
9 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, Nirnimesh
Visibility:
Public.

Description

Verify that sync updates_received is 0 on browser restart. http://crbug.com/78548 details a bug in password sync where every password is committed on browser restart. This patch adds a check to the "RestartBrowser" pyauto test, which ensures that the value of updates_received is 0 after restart. BUG=78548 TEST=sync.SyncTest.testRestartBrowser Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80708

Patch Set 1 : "" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/automation/testing_automation_provider.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/test/functional/sync.py View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Raghu Simha
Nick, please review. Thanks.
9 years, 8 months ago (2011-04-06 21:34:34 UTC) #1
ncarter (slow)
9 years, 8 months ago (2011-04-06 21:45:17 UTC) #2
On 2011/04/06 21:34:34, rsimha wrote:
> Nick, please review. Thanks.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698