Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: fix_encoding.py

Issue 6799021: Switch from xml.dom.minidom to xml.etree (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gclient_utils.py » ('j') | rietveld.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fix_encoding.py
diff --git a/fix_encoding.py b/fix_encoding.py
index 87e54a579054aa1a9f5dee678b82b33ecc1d2853..61bd742b495043b97a653a4fd6fda40eca087a52 100644
--- a/fix_encoding.py
+++ b/fix_encoding.py
@@ -81,6 +81,8 @@ def fix_win_sys_argv(encoding):
if _SYS_ARGV_PROCESSED:
return False
+ # These types are available on linux but not Mac.
+ # pylint: disable=E0611,F0401
from ctypes import byref, c_int, POINTER, windll, WINFUNCTYPE
from ctypes.wintypes import LPCWSTR, LPWSTR
@@ -186,6 +188,8 @@ class WinUnicodeConsoleOutput(WinUnicodeOutputBase):
self._console_handle = console_handle
# Loads the necessary function.
+ # These types are available on linux but not Mac.
+ # pylint: disable=E0611,F0401
from ctypes import byref, GetLastError, POINTER, windll, WINFUNCTYPE
from ctypes.wintypes import BOOL, DWORD, HANDLE, LPWSTR
from ctypes.wintypes import LPVOID # pylint: disable=E0611
@@ -266,6 +270,8 @@ class WinUnicodeOutput(WinUnicodeOutputBase):
def win_handle_is_a_console(handle):
"""Returns True if a Windows file handle is a handle to a console."""
+ # These types are available on linux but not Mac.
+ # pylint: disable=E0611,F0401
from ctypes import byref, POINTER, windll, WINFUNCTYPE
from ctypes.wintypes import BOOL, DWORD, HANDLE
@@ -297,6 +303,8 @@ def win_get_unicode_stream(stream, excepted_fileno, output_handle, encoding):
"""
old_fileno = getattr(stream, 'fileno', lambda: None)()
if old_fileno == excepted_fileno:
+ # These types are available on linux but not Mac.
+ # pylint: disable=E0611,F0401
from ctypes import windll, WINFUNCTYPE
from ctypes.wintypes import DWORD, HANDLE
« no previous file with comments | « no previous file | gclient_utils.py » ('j') | rietveld.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698