Switch from xml.dom.minidom to xml.etree

rietveld.py

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Defines class Rietveld to easily access a rietveld instance.
 
 Security implications:
 
 The following hypothesis are made:
 - Rietveld enforces:
   - Nobody else than issue owner can upload a patch set
@@ skipping 16 matching lines @@
   except ImportError:
     # Import the one included in depot_tools.
     sys.path.append(os.path.join(os.path.dirname(__file__), 'third_party'))
     import simplejson as json  # pylint: disable=F0401
 
 from third_party import upload
 import patch
 
 # Hack out upload logging.info()
 upload.logging = logging.getLogger('upload')
-upload.logging.setLevel(logging.WARNING)
+# Mac pylint chocke on this line.

[Dirk Pranke, 2011/04/07 02:09:23]

Nit. "Mac pylint chokes on this line"

+upload.logging.setLevel(logging.WARNING)  # pylint: disable=E1103
 
 
 class Rietveld(object):
   """Accesses rietveld."""
   def __init__(self, url, email, password):
     self.issue = None
     self.user = email
     self.url = url
     self._get_creds = lambda: (email, password)
     self._xsrf_token = None
@@ skipping 147 matching lines @@
         if e.code not in (500, 502, 503):
           raise
       except urllib2.URLError, e:
         if retry >= (maxtries - 1):
           raise
         if not 'Name or service not known' in e.reason:
           # Usually internal GAE flakiness.
           raise
       # If reaching this line, loop again. Uses a small backoff.
       time.sleep(1+maxtries*2)