Issue 6799017: Changes 'Open all' bookmarks to not recurse through nested folders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6799017: Changes 'Open all' bookmarks to not recurse through nested folders. (Closed)

Created:
9 years, 8 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Changes 'Open all' bookmarks to not recurse through nested folders. BUG=20781 TEST=covered by unit tests. R=brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80709

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -36 lines)			Patch
M	chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_utils.h	View	1 chunk	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_utils.cc	View	5 chunks	+24 lines, -22 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_context_menu_test.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

sky

Sadly it looks like the html bookmark manager doesn't use this code. I'll fix that ...

9 years, 8 months ago (2011-04-06 16:59:45 UTC) #1

LGTM