presubmit_support.py - Issue 6794057: Use subprocess2 so check_call() can be use consistently in presubmit checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_support.py

Issue 6794057: Use subprocess2 so check_call() can be use consistently in presubmit checks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_support.py

diff --git a/presubmit_support.py b/presubmit_support.py

index fcc6a8555c036a4a469958cb1fa12e5d19f9c7eb..4df39c02b485391ba4ff0bd0b69b2e3395120e22 100755

--- a/presubmit_support.py

+++ b/presubmit_support.py

@@ -24,7 +24,6 @@ import os # Somewhat exposed through the API.

import pickle # Exposed through the API.

import random

import re # Exposed through the API.

-import subprocess # Exposed through the API.

import sys # Parts exposed through API.

import tempfile # Exposed through the API.

import time

@@ -50,6 +49,7 @@ import gclient_utils

import owners

import presubmit_canned_checks

import scm

+import subprocess2 as subprocess # Exposed through the API.

# Ask for feedback only once in program lifetime.

« no previous file with comments | « no previous file | no next file » | no next file with comments »