Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 6794047: Fix overlapping registers in external array stores on x64. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1873 matching lines...) Expand 10 before | Expand all | Expand 10 after
1884 ASSERT((representation.IsInteger32() && array_type != kExternalFloatArray) || 1884 ASSERT((representation.IsInteger32() && array_type != kExternalFloatArray) ||
1885 (representation.IsDouble() && array_type == kExternalFloatArray)); 1885 (representation.IsDouble() && array_type == kExternalFloatArray));
1886 ASSERT(instr->external_pointer()->representation().IsExternal()); 1886 ASSERT(instr->external_pointer()->representation().IsExternal());
1887 ASSERT(instr->key()->representation().IsInteger32()); 1887 ASSERT(instr->key()->representation().IsInteger32());
1888 1888
1889 LOperand* external_pointer = UseRegister(instr->external_pointer()); 1889 LOperand* external_pointer = UseRegister(instr->external_pointer());
1890 bool val_is_temp_register = array_type == kExternalPixelArray || 1890 bool val_is_temp_register = array_type == kExternalPixelArray ||
1891 array_type == kExternalFloatArray; 1891 array_type == kExternalFloatArray;
1892 LOperand* val = val_is_temp_register 1892 LOperand* val = val_is_temp_register
1893 ? UseTempRegister(instr->value()) 1893 ? UseTempRegister(instr->value())
1894 : UseRegister(instr->key()); 1894 : UseRegister(instr->value());
1895 LOperand* key = UseRegister(instr->key()); 1895 LOperand* key = UseRegister(instr->key());
1896 1896
1897 return new LStoreKeyedSpecializedArrayElement(external_pointer, 1897 return new LStoreKeyedSpecializedArrayElement(external_pointer,
1898 key, 1898 key,
1899 val); 1899 val);
1900 } 1900 }
1901 1901
1902 1902
1903 LInstruction* LChunkBuilder::DoStoreKeyedGeneric(HStoreKeyedGeneric* instr) { 1903 LInstruction* LChunkBuilder::DoStoreKeyedGeneric(HStoreKeyedGeneric* instr) {
1904 LOperand* object = UseFixed(instr->object(), rdx); 1904 LOperand* object = UseFixed(instr->object(), rdx);
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
2109 2109
2110 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) { 2110 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) {
2111 HEnvironment* outer = current_block_->last_environment()->outer(); 2111 HEnvironment* outer = current_block_->last_environment()->outer();
2112 current_block_->UpdateEnvironment(outer); 2112 current_block_->UpdateEnvironment(outer);
2113 return NULL; 2113 return NULL;
2114 } 2114 }
2115 2115
2116 } } // namespace v8::internal 2116 } } // namespace v8::internal
2117 2117
2118 #endif // V8_TARGET_ARCH_X64 2118 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698