Issue 6794042: [Sync] Roll google-cache-invalidation to @78

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6794042: [Sync] Roll google-cache-invalidation to @78 (Closed)

Created:
9 years, 8 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Zea, tim (not reviewing)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Sync] Roll google-cache-invalidation to @78 This removes the explicit dependency on base/scoped_ptr.h. Also set chromium_code=1, as all compile warnings/errors with that setting have been fixed. BUG=77804 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80431 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80517

Patch Set 1 #

Patch Set 2 : Roll to @78 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	DEPS	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/cacheinvalidation/cacheinvalidation.gyp	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

akalin

Oops, he's on vacation. +tim for review. On 2011/04/05 01:44:57, akalin wrote: > +zea for ...

9 years, 8 months ago (2011-04-05 01:45:19 UTC) #2

akalin

Failed on Linux x86 builder with: third_party/cacheinvalidation/files/src/google/cacheinvalidation/registration-update-manager.cc:642:warning: 'result' may be used uninitialized in this function ...

9 years, 8 months ago (2011-04-05 09:40:58 UTC) #4

akalin

9 years, 8 months ago (2011-04-05 09:57:52 UTC) #5

Fixed in @78, rolling to that instead.

Checking in again as soon as trybots pass.

On 2011/04/05 09:40:58, akalin wrote:
> Failed on Linux x86 builder with:
> 
>
third_party/cacheinvalidation/files/src/google/cacheinvalidation/registration-update-manager.cc:642:warning:
> 'result' may be used uninitialized in this function
> make: ***
>
[out/Release/obj.target/cacheinvalidation/third_party/cacheinvalidation/files/src/google/cacheinvalidation/registration-update-manager.o]
> Error 1
> 
> On 2011/04/05 04:14:53, nzea wrote:
> > LGTM

Expand Messages | Collapse Messages