Issue 6794041: Use placement new for zone objects in hydrogen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6794041: Use placement new for zone objects in hydrogen. (Closed)

Created:
9 years, 8 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Use placement new for zone objects in hydrogen.

Patch Set 1 #

Total comments: 2

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+304 lines, -251 lines)			Patch
	M	src/hydrogen.h	View		10 chunks	+22 lines, -4 lines	0 comments	Download
	M	src/hydrogen.cc	View		122 chunks	+282 lines, -247 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM once you have reindented all of the multi-line argument lists. http://codereview.chromium.org/6794041/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): ...

9 years, 8 months ago (2011-04-05 15:19:37 UTC) #2

Vitaly Repeshko

9 years, 8 months ago (2011-04-05 18:49:43 UTC) #3

http://codereview.chromium.org/6794041/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/6794041/diff/1/src/hydrogen.cc#newcode2945
src/hydrogen.cc:2945: expr->flags(),
On 2011/04/05 15:19:37, Mads Ager wrote:
> You need to reindent all of these multi line occurrences.

Done. All of them.

Expand Messages | Collapse Messages