Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 6794020: upload.py has a raw_input() that keeps on throwing crap, try to trap it as much as possible. (Closed)

Created:
9 years, 8 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

upload.py has a raw_input() that keeps on throwing crap, try to trap it as much as possible. Otherwise I get useless stack traces and the user too. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80338

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M gcl.py View 1 chunk +4 lines, -1 line 0 comments Download
M git_cl.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
9 years, 8 months ago (2011-04-04 16:14:09 UTC) #1
Dirk Pranke
9 years, 8 months ago (2011-04-04 17:27:51 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698