Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: src/execution.cc

Issue 6794019: Simplify isolates access during stack iteration (WAS: Move SafeStackFrameIterator::active_count_...) (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: A couple more changes Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/debug.cc ('k') | src/frames.h » ('j') | src/frames.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 693 matching lines...) Expand 10 before | Expand all | Expand 10 after
704 if (isolate->debug()->disable_break()) { 704 if (isolate->debug()->disable_break()) {
705 return isolate->heap()->undefined_value(); 705 return isolate->heap()->undefined_value();
706 } 706 }
707 707
708 // Ignore debug break during bootstrapping. 708 // Ignore debug break during bootstrapping.
709 if (isolate->bootstrapper()->IsActive()) { 709 if (isolate->bootstrapper()->IsActive()) {
710 return isolate->heap()->undefined_value(); 710 return isolate->heap()->undefined_value();
711 } 711 }
712 712
713 { 713 {
714 JavaScriptFrameIterator it; 714 JavaScriptFrameIterator it(isolate);
715 ASSERT(!it.done()); 715 ASSERT(!it.done());
716 Object* fun = it.frame()->function(); 716 Object* fun = it.frame()->function();
717 if (fun && fun->IsJSFunction()) { 717 if (fun && fun->IsJSFunction()) {
718 // Don't stop in builtin functions. 718 // Don't stop in builtin functions.
719 if (JSFunction::cast(fun)->IsBuiltin()) { 719 if (JSFunction::cast(fun)->IsBuiltin()) {
720 return isolate->heap()->undefined_value(); 720 return isolate->heap()->undefined_value();
721 } 721 }
722 GlobalObject* global = JSFunction::cast(fun)->context()->global(); 722 GlobalObject* global = JSFunction::cast(fun)->context()->global();
723 // Don't stop in debugger functions. 723 // Don't stop in debugger functions.
724 if (isolate->debug()->IsDebugGlobal(global)) { 724 if (isolate->debug()->IsDebugGlobal(global)) {
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
782 return isolate->TerminateExecution(); 782 return isolate->TerminateExecution();
783 } 783 }
784 if (stack_guard->IsInterrupted()) { 784 if (stack_guard->IsInterrupted()) {
785 stack_guard->Continue(INTERRUPT); 785 stack_guard->Continue(INTERRUPT);
786 return isolate->StackOverflow(); 786 return isolate->StackOverflow();
787 } 787 }
788 return isolate->heap()->undefined_value(); 788 return isolate->heap()->undefined_value();
789 } 789 }
790 790
791 } } // namespace v8::internal 791 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/debug.cc ('k') | src/frames.h » ('j') | src/frames.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698