Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/debug.h

Issue 6794019: Simplify isolates access during stack iteration (WAS: Move SafeStackFrameIterator::active_count_...) (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: A couple more changes Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/cpu-profiler.cc ('k') | src/debug.cc » ('j') | src/frames.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 845 matching lines...) Expand 10 before | Expand all | Expand 10 after
856 856
857 // This class is used for entering the debugger. Create an instance in the stack 857 // This class is used for entering the debugger. Create an instance in the stack
858 // to enter the debugger. This will set the current break state, make sure the 858 // to enter the debugger. This will set the current break state, make sure the
859 // debugger is loaded and switch to the debugger context. If the debugger for 859 // debugger is loaded and switch to the debugger context. If the debugger for
860 // some reason could not be entered FailedToEnter will return true. 860 // some reason could not be entered FailedToEnter will return true.
861 class EnterDebugger BASE_EMBEDDED { 861 class EnterDebugger BASE_EMBEDDED {
862 public: 862 public:
863 EnterDebugger() 863 EnterDebugger()
864 : isolate_(Isolate::Current()), 864 : isolate_(Isolate::Current()),
865 prev_(isolate_->debug()->debugger_entry()), 865 prev_(isolate_->debug()->debugger_entry()),
866 it_(isolate_),
866 has_js_frames_(!it_.done()), 867 has_js_frames_(!it_.done()),
867 save_(isolate_) { 868 save_(isolate_) {
868 Debug* debug = isolate_->debug(); 869 Debug* debug = isolate_->debug();
869 ASSERT(prev_ != NULL || !debug->is_interrupt_pending(PREEMPT)); 870 ASSERT(prev_ != NULL || !debug->is_interrupt_pending(PREEMPT));
870 ASSERT(prev_ != NULL || !debug->is_interrupt_pending(DEBUGBREAK)); 871 ASSERT(prev_ != NULL || !debug->is_interrupt_pending(DEBUGBREAK));
871 872
872 // Link recursive debugger entry. 873 // Link recursive debugger entry.
873 debug->set_debugger_entry(this); 874 debug->set_debugger_entry(this);
874 875
875 // Store the previous break id and frame id. 876 // Store the previous break id and frame id.
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
1045 1046
1046 DISALLOW_COPY_AND_ASSIGN(MessageDispatchHelperThread); 1047 DISALLOW_COPY_AND_ASSIGN(MessageDispatchHelperThread);
1047 }; 1048 };
1048 1049
1049 1050
1050 } } // namespace v8::internal 1051 } } // namespace v8::internal
1051 1052
1052 #endif // ENABLE_DEBUGGER_SUPPORT 1053 #endif // ENABLE_DEBUGGER_SUPPORT
1053 1054
1054 #endif // V8_DEBUG_H_ 1055 #endif // V8_DEBUG_H_
OLDNEW
« no previous file with comments | « src/cpu-profiler.cc ('k') | src/debug.cc » ('j') | src/frames.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698