Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 6793055: [login_manager] Allow new owner keys to be pushed with StorePolicy (Closed)

Created:
9 years, 8 months ago by Chris Masone
Modified:
9 years, 7 months ago
Reviewers:
DaveMoore
CC:
chromium-os-reviews_chromium.org, Chris Masone, Mattias Nissler (ping if slow)
Visibility:
Public.

Description

[login_manager] Allow new owner keys to be pushed with StorePolicy To handle initial enrollment and emergency key rotation (the current key has been compromised), we will allow any policy stored before the user has begun her session to clobber the existing key/policy. To perform normal key rotation, we'll validate the signature on the key blob in the policy with the currently registered key and, iff it checks out, replace the stored key. BUG=13746 TEST=Unit tests, and login_RemoteOwnership (to be landed soon), and login_OwnershipApi Change-Id: Id4c6e8f3d37224a03ac631ff19bb6daa04ff20eb Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=87fd640

Patch Set 1 #

Patch Set 2 : remove some debugging code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -63 lines) Patch
M Makefile View 1 chunk +1 line, -1 line 0 comments Download
M mock_owner_key.h View 1 2 chunks +7 lines, -3 lines 0 comments Download
M nss_util.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M nss_util.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M owner_key.h View 4 chunks +19 lines, -4 lines 0 comments Download
M owner_key.cc View 1 5 chunks +47 lines, -12 lines 0 comments Download
M owner_key_unittest.cc View 1 4 chunks +82 lines, -5 lines 0 comments Download
M session_manager_service.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M session_manager_service.cc View 1 8 chunks +62 lines, -17 lines 0 comments Download
M session_manager_unittest.cc View 1 14 chunks +36 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Chris Masone
9 years, 8 months ago (2011-04-05 23:34:53 UTC) #1
DaveMoore
9 years, 8 months ago (2011-04-05 23:45:10 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698