Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 6793042: Add sample extension for preference access. (Closed)

Created:
9 years, 8 months ago by Bernhard Bauer
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Add sample extension for preference access. BUG=71067 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82091

Patch Set 1 #

Total comments: 6

Patch Set 2 : comments #

Patch Set 3 : comments #

Messages

Total messages: 6 (0 generated)
Bernhard Bauer
Please review.
9 years, 8 months ago (2011-04-14 09:29:24 UTC) #1
kurrik.chromium
http://codereview.chromium.org/6793042/diff/1/chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html File chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html (right): http://codereview.chromium.org/6793042/diff/1/chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html#newcode1 chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html:1: <html> Please add a DOCTYPE to popups http://codereview.chromium.org/6793042/diff/1/chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html#newcode7 chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html:7: ...
9 years, 8 months ago (2011-04-14 17:53:43 UTC) #2
Bernhard Bauer
http://codereview.chromium.org/6793042/diff/1/chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html File chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html (right): http://codereview.chromium.org/6793042/diff/1/chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html#newcode1 chrome/common/extensions/docs/examples/api/preferences/enableReferrer/popup.html:1: <html> On 2011/04/14 17:53:43, kurrik.chromium wrote: > Please add ...
9 years, 8 months ago (2011-04-15 16:34:32 UTC) #3
kurrik.chromium
LGTM. Thanks!
9 years, 8 months ago (2011-04-15 17:35:06 UTC) #4
M-A Ruel
The commit queue doesn't support binary files yet, since the try server doesn't support it ...
9 years, 8 months ago (2011-04-18 18:50:33 UTC) #5
commit-bot: I haz the power
9 years, 8 months ago (2011-04-18 18:54:43 UTC) #6
Failed to request the patch to try.
HTTP Error 302: Found

Powered by Google App Engine
This is Rietveld 408576698