Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 6793019: Cleanup of FACTORY macro and fix Irregexp Interpreter build in test-regexp.cc (Closed)

Created:
9 years, 8 months ago by Peter Varga
Modified:
9 years, 7 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

Cleanup of FACTORY macro and fix Irregexp Interpreter build in test-regexp.cc BUG=none TEST=none Patch from Peter Varga <pvarga@inf.u-szeged.hu>;.

Patch Set 1 #

Patch Set 2 : Fix factory variables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -35 lines) Patch
M test/cctest/test-regexp.cc View 1 27 chunks +52 lines, -35 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Varga
9 years, 8 months ago (2011-04-04 14:52:47 UTC) #1
Vitaly Repeshko
9 years, 8 months ago (2011-04-04 17:50:09 UTC) #2
LGTM. I'll land.


Thanks,
Vitaly

Powered by Google App Engine
This is Rietveld 408576698