In LCodeGen::DoDeferredLInstanceOfKnownGlobal emit safepoint with registers for the call to stub.

In LCodeGen::DoDeferredLInstanceOfKnownGlobal emit safepoint with registers for the call to stub.

Committed: http://code.google.com/p/v8/source/detail?r=7541

[Vyacheslav Egorov (Chromium), 2011-04-04 11:35:33]

Kevin, can you take a look?

This is IA32-only. If approach looks good to you I will port it to x64/arm.

[Vyacheslav Egorov (Chromium), 2011-04-04 11:38:33]

redirecting to Florian.

[fschneider, 2011-04-04 11:54:11]

http://codereview.chromium.org/6793017/diff/1/src/ia32/lithium-codegen-ia32.h
File src/ia32/lithium-codegen-ia32.h (right):

http://codereview.chromium.org/6793017/diff/1/src/ia32/lithium-codegen-ia32.h...
src/ia32/lithium-codegen-ia32.h:180: ContextMode context_mode =
CONTEXT_ADJUSTED,
I'm hesitating using default arguments here (especially two in a row). There is
always the danger, that people in the future copy/paste from a call site without
noticing default values.

The ContextMode should disappear in the future once we converted all calling
instructions to take the context as input operand explicitly.

Maybe a helper like DeferredCallCode / DeferredCallRuntime would be a little
nicer  to use. It can take the number of arguments as parameters.

[Vyacheslav Egorov (Chromium), 2011-04-04 14:42:09]

Here is another version (again only ia32).

[fschneider, 2011-04-04 14:56:34]

LGTM for ia32.

http://codereview.chromium.org/6793017/diff/1003/src/ia32/lithium-codegen-ia3...
File src/ia32/lithium-codegen-ia32.cc (right):

http://codereview.chromium.org/6793017/diff/1003/src/ia32/lithium-codegen-ia3...
src/ia32/lithium-codegen-ia32.cc:643: ASSERT(kind == Safepoint::kWithRegisters
|| !safepoint_registers_pushed_);
You could assert stronger:

ASSERT((kind == Safepoint::kWithRegisters) == safepoint_registers_pushed_)

[Vyacheslav Egorov (Chromium), 2011-04-06 17:51:44]

I've ported fix from ia32 to ARM and x64. 

Please take another look.

[fschneider, 2011-04-07 11:28:30]

LGTM.

http://codereview.chromium.org/6793017/diff/6001/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/6793017/diff/6001/src/x64/lithium-codegen-x64....
src/x64/lithium-codegen-x64.cc:1985: //
Remove extra line.

http://codereview.chromium.org/6793017/diff/6001/test/mjsunit/regress/regress...
File test/mjsunit/regress/regress-78270.js (right):

http://codereview.chromium.org/6793017/diff/6001/test/mjsunit/regress/regress...
test/mjsunit/regress/regress-78270.js:1: 
Insert copyright header.