Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: chrome/browser/sessions/session_service_unittest.cc

Issue 6793008: Replacing base::DIR_TEMP with ScopedTempDir when appropriate. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Paweł's comments on Round 2. Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sessions/session_service_unittest.cc
diff --git a/chrome/browser/sessions/session_service_unittest.cc b/chrome/browser/sessions/session_service_unittest.cc
index d2d9942adf711f7d0d72285f09f5187411e785bc..d10548e963d6013c4f69ea5f818d07bc8c8df821 100644
--- a/chrome/browser/sessions/session_service_unittest.cc
+++ b/chrome/browser/sessions/session_service_unittest.cc
@@ -5,6 +5,7 @@
#include "base/file_util.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/scoped_vector.h"
+#include "base/memory/scoped_temp_dir.h"
#include "base/path_service.h"
#include "base/stl_util-inl.h"
#include "base/string_number_conversions.h"
@@ -36,8 +37,8 @@ class SessionServiceTest : public BrowserWithTestWindowTest,
BrowserWithTestWindowTest::SetUp();
std::string b = base::Int64ToString(base::Time::Now().ToInternalValue());
- PathService::Get(base::DIR_TEMP, &path_);
- path_ = path_.Append(FILE_PATH_LITERAL("SessionTestDirs"));
+ ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
+ path_ = temp_dir_.path().Append(FILE_PATH_LITERAL("SessionTestDirs"));
file_util::CreateDirectory(path_);
path_deleter_.reset(new FileAutoDeleter(path_));
path_ = path_.AppendASCII(b);
@@ -133,6 +134,7 @@ class SessionServiceTest : public BrowserWithTestWindowTest,
int sync_save_count_;
// Path used in testing.
+ ScopedTempDir temp_dir_;
FilePath path_;
scoped_ptr<FileAutoDeleter> path_deleter_;

Powered by Google App Engine
This is Rietveld 408576698