Add the xrender backend to the window manager.

x11/real_x_connection.cc

 // Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "window_manager/x11/real_x_connection.h"
 
 extern "C" {
 #include <xcb/composite.h>
 #include <xcb/damage.h>
 #include <xcb/randr.h>
 #include <xcb/shape.h>
 #include <xcb/sync.h>
 #include <xcb/xfixes.h>
 #include <X11/extensions/shape.h>
 #include <X11/extensions/sync.h>
 #include <X11/extensions/Xcomposite.h>
 #include <X11/extensions/Xdamage.h>
+#include <X11/extensions/Xrender.h>
 #include <X11/Xatom.h>
 #include <X11/Xlib-xcb.h>
 #include <X11/Xutil.h>
 #include <X11/XKBlib.h>
 }
 
 #include "base/string_util.h"
 #include "window_manager/geometry.h"
 #include "window_manager/util.h"
 #include "window_manager/x11/x_connection_internal.h"
@@ skipping 1309 matching lines @@
       xcb_query_pointer_reply(xcb_conn_, cookie, &error));
   scoped_ptr_malloc<xcb_generic_error_t> scoped_error(error);
   if (error || !reply.get()) {
     LOG(WARNING) << "Querying pointer position failed";
     return false;
   }
   absolute_pos_out->reset(reply->root_x, reply->root_y);
   return true;
 }
 
+bool RealXConnection::RenderQueryExtension() {
+  int render_event, render_error;
+  if (!XRenderQueryExtension (display_, &render_event, &render_error))

[Daniel Erat, 2011/04/02 14:54:36]

why not do "return XRenderQueryExtension(...)"?

[marcheu, 2011/04/04 19:55:58]

Done.

+    return false;
+  return true;
+}
+
+XPicture RealXConnection::RenderCreatePicture(XDrawable drawable, int depth) {
+  XRenderPictFormat *format;
+  XRenderPictureAttributes pa;
+
+  format = XRenderFindStandardFormat(display_,

[Daniel Erat, 2011/04/02 14:54:36]

nit: move 'display_' to the beginning of the next line

[marcheu, 2011/04/04 19:55:58]

Done.

+    depth == 24 ? PictStandardRGB24 : PictStandardARGB32);
+  pa.repeat = True;
+  XPicture r = XRenderCreatePicture(display_, drawable, format, CPRepeat, &pa);
+  return r;
+}
+
+XPixmap RealXConnection::CreatePixmapFromData(char* data, const Size& size) {

[Daniel Erat, 2011/04/02 14:54:36]

see other comment about using ImageContainer instead

[marcheu, 2011/04/04 19:55:58]

Done.

+  int data_size = size.width * size.height * 4;
+  char* pixmap_data = (char*)malloc(data_size);

[Daniel Erat, 2011/04/02 14:54:36]

use static_cast

[marcheu, 2011/04/02 23:31:38]

Note to self: add a comment that XDestroyImage will free() this.

[marcheu, 2011/04/04 19:55:58]

Done.

+
+  /* premultiply the RGB channels */
+  memcpy(pixmap_data, data, data_size);
+  for(int i = 0; i<size.width * size.height; i++) {

[Daniel Erat, 2011/04/02 14:54:36]

add space between for and ( and around <

[marcheu, 2011/04/04 19:55:58]

Done.

+     pixmap_data[i*4+0] = pixmap_data[i*4+0] * pixmap_data[i*4+3] / 255;
+     pixmap_data[i*4+1] = pixmap_data[i*4+1] * pixmap_data[i*4+3] / 255;
+     pixmap_data[i*4+2] = pixmap_data[i*4+2] * pixmap_data[i*4+3] / 255;
+  }
+
+  XPixmap pixmap = XCreatePixmap(display_, root_, size.width, size.height, 32);
+
+  XImage* image = XCreateImage (display_,
+                           DefaultVisual(display_, DefaultScreen(display_)),

[Daniel Erat, 2011/04/02 14:54:36]

fix indenting

[marcheu, 2011/04/04 19:55:58]

Done.

+                           32,

[Daniel Erat, 2011/04/02 14:54:36]

nit: mind labeling the ambiguous arguments with trailing comments aligned along
the right?

    32,  // depth
    ...
    0,   // whatever
    pixmap_data,
    size.width, size.height,
    32,  // ???
    0);  // ???

[marcheu, 2011/04/04 19:55:58]

Done.

+                           ZPixmap,
+                           0,
+                           pixmap_data,
+                           size.width, size.height,
+                           32, 0);
+
+  GC gc = XCreateGC (display_, pixmap, 0, NULL);

[Daniel Erat, 2011/04/02 14:54:36]

remove space

[marcheu, 2011/04/04 19:55:58]

Done.

+  if (!gc) {
+    XDestroyImage (image);

[Daniel Erat, 2011/04/02 14:54:36]

remove space

[marcheu, 2011/04/04 19:55:58]

Done.

+    XFreePixmap (display_, pixmap);

[Daniel Erat, 2011/04/02 14:54:36]

remove space

[marcheu, 2011/04/04 19:55:58]

Done.

+    return None;
+  }
+
+  XPutImage (display_, pixmap, gc, image, 0, 0, 0, 0, size.width, size.height);

[Daniel Erat, 2011/04/02 14:54:36]

ditto

[marcheu, 2011/04/04 19:55:58]

Done.

+  XDestroyImage(image);
+
+  XFreeGC (display_, gc);
+
+  return pixmap;
+}
+
+void RealXConnection::RenderComposite(bool blend, XPicture src, XPicture mask,
+    XPicture dst, Point srcpos, Point maskpos, Matrix4 transform, Size size)

[Daniel Erat, 2011/04/02 14:54:36]

fix indenting

[marcheu, 2011/04/04 19:55:58]

Done.

+{

[Daniel Erat, 2011/04/02 14:54:36]

move to end of previous line

[marcheu, 2011/04/04 19:55:58]

Done.

+  XTransform xform = {{
+  { XDoubleToFixed( size.width/(float)transform[0][0] ),

[Daniel Erat, 2011/04/02 14:54:36]

fix indenting/spacing/casts

[marcheu, 2011/04/04 19:55:58]

Tried to do something about it, not sure exactly how it should be.

+      XDoubleToFixed( transform[1][0] ),
+      XDoubleToFixed( transform[2][0] ) },
+  { XDoubleToFixed( transform[0][1] ),
+      XDoubleToFixed( size.height/(float)transform[1][1] ),
+      XDoubleToFixed( transform[2][1] ) },
+  { XDoubleToFixed( 0.0 ),
+      XDoubleToFixed( 0.0 ),
+      XDoubleToFixed( 1.0 ) }
+  }};
+  Point dstpos(transform[3][0], transform[3][1]);
+
+  // Don't use transform/filtering all the time,
+  // there are performance implications in doing so.
+  if ( (size.width != transform[0][0]) || (size.height != transform[1][1] ) ) {

[Daniel Erat, 2011/04/02 14:54:36]

remove extra spaces here and below

[marcheu, 2011/04/04 19:55:58]

Done.

+    XRenderSetPictureTransform( display_, src, &xform );
+    XRenderSetPictureFilter( display_, src, FilterBilinear, 0, 0 );
+  }
+
+  int op = blend ? PictOpOver : PictOpSrc;
+  XRenderComposite(display_, op, src, mask, dst,
+                   (int)srcpos.x, (int)srcpos.y, (int)maskpos.x, (int)maskpos.y,

[Daniel Erat, 2011/04/02 14:54:36]

c++ casts, and group related params together on lines:

  srcpos.x, srcpos.y,
  maskpos.x, maskpos.y,
  dstpos.x, dstpos.y,
  transform...)

[marcheu, 2011/04/04 19:55:58]

Done.

+                   (int)dstpos.x, (int)dstpos.y,
+                   (int)transform[0][0], (int)transform[1][1]);
+}
+
+void RealXConnection::RenderFreePicture(XPicture pict)
+{

[Daniel Erat, 2011/04/02 14:54:36]

...

[marcheu, 2011/04/04 19:55:58]

Done.

+  XRenderFreePicture(display_, pict);
+}
+
+void RealXConnection::RenderFillRectangle(XPicture dst,
+                                          float red,
+                                          float green,
+                                          float blue,
+                                          Point pos,
+                                          Size size)
+{

[Daniel Erat, 2011/04/02 14:54:36]

...

[marcheu, 2011/04/04 19:55:58]

Done.

+  XRenderColor c;
+
+  c.red = red * 0xffff;
+  c.green = green * 0xffff;
+  c.blue = blue * 0xffff;
+  c.alpha = 0xffff;
+  XRenderFillRectangle(display_, PictOpSrc, dst, &c,
+                       pos.x, pos.y, size.width, size.height);
+}
+
 void RealXConnection::Free(void* item) {
   XFree(item);
 }
 
 XVisualInfo* RealXConnection::GetVisualInfo(long mask,
                                             XVisualInfo* visual_template,
                                             int* item_count) {
   return XGetVisualInfo(display_, mask, visual_template, item_count);
 }
 
@@ skipping 153 matching lines @@
   string message;
   StringAppendV(&message, format, ap);
   va_end(ap);
 
   LOG(WARNING) << "Got XCB error while " << message << ": "
                << GetErrorText(error->error_code);
   return false;
 }
 
 }  // namespace window_manager