Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: subprocess2.py

Issue 6792060: Make more tests pass on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: subprocess2.py
diff --git a/subprocess2.py b/subprocess2.py
index acba499ae13d38fab3236ea61c0f518cb902826e..77fda58d291c2f552f5fb6793de0ebc6a36aa836 100644
--- a/subprocess2.py
+++ b/subprocess2.py
@@ -51,7 +51,7 @@ def kill_pid(pid):
"""Kills a process by its process id."""
try:
# Unable to import 'module'
- # pylint: disable=F0401
+ # pylint: disable=E1101,F0401
import signal
return os.kill(pid, signal.SIGKILL)
except ImportError:
@@ -105,6 +105,8 @@ def get_english_env(env):
Returns None if it is unnecessary.
"""
+ if sys.platform == 'win32':
+ return None
env = env or os.environ
# Test if it is necessary at all.

Powered by Google App Engine
This is Rietveld 408576698