Make more tests pass on Windows.

subprocess2.py

 # coding=utf8
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Collection of subprocess wrapper functions.
 
 In theory you shouldn't need anything else in subprocess, or this module failed.
 """
 
 from __future__ import with_statement
@@ skipping 33 matching lines @@
     return '\n'.join(filter(None, (out, self.stdout, self.stderr)))
 
 
 ## Utility functions
 
 
 def kill_pid(pid):
   """Kills a process by its process id."""
   try:
     # Unable to import 'module'
-    # pylint: disable=F0401
+    # pylint: disable=E1101,F0401
     import signal
     return os.kill(pid, signal.SIGKILL)
   except ImportError:
     pass
 
 
 def kill_win(process):
   """Kills a process with its windows handle.
 
   Has no effect on other platforms.
@@ skipping 33 matching lines @@
     SUBPROCESS_CLEANUP_HACKED = True
 
 
 def get_english_env(env):
   """Forces LANG and/or LANGUAGE to be English.
 
   Forces encoding to utf-8 for subprocesses.
 
   Returns None if it is unnecessary.
   """
+  if sys.platform == 'win32':
+    return None
   env = env or os.environ
 
   # Test if it is necessary at all.
   is_english = lambda name: env.get(name, 'en').startswith('en')
 
   if is_english('LANG') and is_english('LANGUAGE'):
     return None
 
   # Requires modifications.
   env = env.copy()
@@ skipping 128 matching lines @@
 
   - Discards stderr. By default sets stderr=STDOUT.
   - Throws if return code is not 0.
   - Works even prior to python 2.7.
   """
   if kwargs.get('stdout') is None:
     kwargs['stdout'] = PIPE
   if kwargs.get('stderr') is None:
     kwargs['stderr'] = STDOUT
   return check_call(args, **kwargs)[0]