Convert drover.py to subprocess2.

Convert drover.py to subprocess2.

R=dpranke@chromium.org
BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80453

[Dirk Pranke, 2011-04-04 19:28:46]

LGTM.

[commit-bot: I haz the power, 2011-04-04 19:36:13]

Presubmit check for 6792029-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/verification/presubmit_shim.py", line 34, in
<module>
    sys.exit(presubmit_support.Main(None))
  File "/b/depot_tools/presubmit_support.py", line 1195, in Main
    options.may_prompt)
  File "/b/depot_tools/presubmit_support.py", line 1062, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 981, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 109, in CheckChangeOnCommit
  File "<string>", line 45, in CommonChecks
  File "<string>", line 76, in RunGitClTests
  File "/mnt/data/b/commit-queue/workdir/depot_tools/tests/local_rietveld.py",
line 90, in start_server
    pipe = subprocess2.VOID
AttributeError: 'module' object has no attribute 'VOID'
Sending crash report ...
  exception: 'module' object has no attribute 'VOID'
  args: ['/mnt/data/b/commit-queue/verification/presubmit_shim.py', '--commit',
'--issue', '6792029', '--patchset', '1', '--name', '6792029-1', '--description',
'Convert drover.py to subprocess2.\n\nR=dpranke@chromium.org\nBUG=\nTEST=\n',
'drover.py']
  stack:   File "/mnt/data/b/commit-queue/verification/pres
  host: vm105-m4.golo.chromium.org
  version: 2.6.5 (r265:79063, Apr 16 2010, 13:57:41) 
[GCC 4.
  user: chrome-bot
  cwd: /mnt/data/b/commit-queue/workdir/depot_tools
A stack trace has been sent to the maintainers.

[commit-bot: I haz the power, 2011-04-04 19:41:33]

Presubmit check for 6792029-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/verification/presubmit_shim.py", line 34, in
<module>
    sys.exit(presubmit_support.Main(None))
  File "/b/depot_tools/presubmit_support.py", line 1195, in Main
    options.may_prompt)
  File "/b/depot_tools/presubmit_support.py", line 1062, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 981, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 109, in CheckChangeOnCommit
  File "<string>", line 45, in CommonChecks
  File "<string>", line 76, in RunGitClTests
  File "/mnt/data/b/commit-queue/workdir/depot_tools/tests/local_rietveld.py",
line 90, in start_server
    pipe = subprocess2.VOID
AttributeError: 'module' object has no attribute 'VOID'
Sending crash report ...
  exception: 'module' object has no attribute 'VOID'
  args: ['/mnt/data/b/commit-queue/verification/presubmit_shim.py', '--commit',
'--issue', '6792029', '--patchset', '1', '--name', '6792029-1', '--description',
'Convert drover.py to subprocess2.\n\nR=dpranke@chromium.org\nBUG=\nTEST=\n',
'drover.py']
  stack:   File "/mnt/data/b/commit-queue/verification/pres
  host: vm105-m4.golo.chromium.org
  version: 2.6.5 (r265:79063, Apr 16 2010, 13:57:41) 
[GCC 4.
  user: chrome-bot
  cwd: /mnt/data/b/commit-queue/workdir/depot_tools
A stack trace has been sent to the maintainers.

[M-A Ruel, 2011-04-04 19:45:48]

Sorry for the noise, I'm trying where the stale subprocess2.pyc is getting
loaded from.

[commit-bot: I haz the power, 2011-04-04 20:53:50]

Presubmit check for 6792029-1 failed and returned exit status -9.
The presubmit check was hung. It took 600.0 seconds to execute and the time
limit is 600.0 seconds.

[dglazkov, 2011-04-15 19:58:52]

This broke drover. Apparently, drover always uses hard-coded chromium repo URL,
and pre-conversion, it would fail silently. Post-conversion, it's throws an
exception:

Traceback (most recent call last):
  File "d:\depot_tools\drover.py", line 553, in <module>
    sys.exit(main())
  File "d:\depot_tools\drover.py", line 549, in main
    return drover(options, args)
  File "d:\depot_tools\drover.py", line 444, in drover
    checkoutRevision(url, revision, branch_url)
  File "d:\depot_tools\drover.py", line 166, in checkoutRevision
    export_map = getBestExportPathsMap2(files_info, revision)
  File "d:\depot_tools\drover.py", line 314, in getBestExportPathsMap2
    revision)):
  File "d:\depot_tools\drover.py", line 100, in isSVNDirectory
    info = getSVNInfo(url, revision)
  File "d:\depot_tools\drover.py", line 68, in getSVNInfo
    ['svn', 'info', '%s@%s' % (url, revision)]).splitlines()
  File "d:\depot_tools\subprocess2.py", line 289, in check_output
    return check_call(args, **kwargs)[0]
  File "d:\depot_tools\subprocess2.py", line 251, in check_call
    returncode, args, kwargs.get('cwd'), out[0], out[1])
subprocess2.CalledProcessError: Command svn info
svn://svn.chromium.org/chrome/trunk/LayoutTests/fast/files/blob-slice-t
est-expected.txt@83873 returned non-zero exit status 1
svn: No such revision 83873

[M-A Ruel, 2011-04-15 20:03:02]

On 2011/04/15 19:58:52, Dimitri Glazkov wrote:
> This broke drover. Apparently, drover always uses hard-coded chromium repo
URL,
> and pre-conversion, it would fail silently. Post-conversion, it's throws an
> exception:
> 
> Traceback (most recent call last):
>   File "d:\depot_tools\drover.py", line 553, in <module>
>     sys.exit(main())
>   File "d:\depot_tools\drover.py", line 549, in main
>     return drover(options, args)
>   File "d:\depot_tools\drover.py", line 444, in drover
>     checkoutRevision(url, revision, branch_url)
>   File "d:\depot_tools\drover.py", line 166, in checkoutRevision
>     export_map = getBestExportPathsMap2(files_info, revision)
>   File "d:\depot_tools\drover.py", line 314, in getBestExportPathsMap2
>     revision)):
>   File "d:\depot_tools\drover.py", line 100, in isSVNDirectory
>     info = getSVNInfo(url, revision)
>   File "d:\depot_tools\drover.py", line 68, in getSVNInfo
>     ['svn', 'info', '%s@%s' % (url, revision)]).splitlines()

need to replace check_output() with capture().

I don't have access to a box until Monday if someone wamts to fix it before.


>   File "d:\depot_tools\subprocess2.py", line 289, in check_output
>     return check_call(args, **kwargs)[0]
>   File "d:\depot_tools\subprocess2.py", line 251, in check_call
>     returncode, args, kwargs.get('cwd'), out[0], out[1])
> subprocess2.CalledProcessError: Command svn info
> svn://svn.chromium.org/chrome/trunk/LayoutTests/fast/files/blob-slice-t
> est-expected.txt@83873 returned non-zero exit status 1
> svn: No such revision 83873