Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 6792011: app-crypt/tpm-tools: backport tpm-tools-1.3.5-r1 from main Gentoo (Closed)

Created:
9 years, 8 months ago by Flameeyes-Gentoo
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

app-crypt/tpm-tools: backport tpm-tools-1.3.5-r1 from main Gentoo This version applies the gold patch directly, without ChromiumOS-specific patching, and also fixes the automagic dependency problem on OpenCryptoki. BUG=chromium-os:13728 TEST=emerge-{x86,arm}-generic (and misc test in Gentoo upstream) Change-Id: I2fbec3fc722f9f307721d481db8873d2b3b62e93 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f4fecce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
A app-crypt/tpm-tools/files/tpm-tools-1.3.1-gold.patch View 1 chunk +13 lines, -0 lines 0 comments Download
A app-crypt/tpm-tools/tpm-tools-1.3.5-r1.ebuild View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Flameeyes-Gentoo
9 years, 8 months ago (2011-04-02 23:04:58 UTC) #1
raymes
I see you've just used the same patch file. Does it apply cleanly (I would ...
9 years, 8 months ago (2011-04-03 17:05:19 UTC) #2
raymes
Upstream bug also filed: http://sourceforge.net/tracker/?func=detail&atid=704358&aid=3272324&group_id=126012 On 2011/04/03 17:05:19, raymes wrote: > I see you've just ...
9 years, 8 months ago (2011-04-03 17:06:27 UTC) #3
Flameeyes-Gentoo
On 2011/04/03 17:05:19, raymes wrote: > I see you've just used the same patch file. ...
9 years, 8 months ago (2011-04-03 19:01:45 UTC) #4
raymes
9 years, 8 months ago (2011-04-03 19:29:21 UTC) #5
Cool. LGTM

On Sun, Apr 3, 2011 at 12:01 PM,  <flameeyes@chromium.org> wrote:
> On 2011/04/03 17:05:19, raymes wrote:
>>
>> I see you've just used the same patch file. Does it apply cleanly (I would
>
> have
>>
>> thought it would look for the wrong file, i.e.
>> tpm-tools-1.3.1/src/data_mgmt/Makefile.am)?
>
> Patches are applied with a variable stripping of directory components from
> the
> source path, in general terms at least the first component is always
> ignored,
> and that one is the one carrying the version. So yes, it works fine with the
> same file ;)
>
> http://codereview.chromium.org/6792011/
>

Powered by Google App Engine
This is Rietveld 408576698