owners.py - Issue 6791018: Add a warning if the current version of python is not 2.5

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: owners.py

Issue 6791018: Add a warning if the current version of python is not 2.5 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Updated to work seamlessly with python 2.5 Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: owners.py

diff --git a/owners.py b/owners.py

index 5aabb60077249a33233c3e08702d47e71b23a1e2..5be7ff6d005b815321d31622651a2606b945ab40 100644

--- a/owners.py

+++ b/owners.py

@@ -18,6 +18,8 @@ BASIC_EMAIL_REGEXP = r'^[\w\-\+\%\.]+\@[\w\-\+\%\.]+$'

def _assert_is_collection(obj):

assert not isinstance(obj, basestring)

+ # Module 'collections' has no 'Iterable' member

+ # pylint: disable=E1101

if hasattr(collections, 'Iterable') and hasattr(collections, 'Sized'):

assert (isinstance(obj, collections.Iterable) and

isinstance(obj, collections.Sized))

« no previous file with comments | « git_cl.py ('k') | presubmit_canned_checks.py » ('j') | no next file with comments »