Issue 6791014: Revert r7483 "Move SafeStackFrameIterator::active_count_ into an isolate."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6791014: Revert r7483 "Move SafeStackFrameIterator::active_count_ into an isolate." (Closed)

Created:
9 years, 8 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Mikhail Naganov

CC:
v8-dev

Visibility:
Public.

Description

Revert r7483 "Move SafeStackFrameIterator::active_count_ into an isolate." It broke the Mac build. Sampler::SampleStack() can't use Isolate::Current() when called from the sampler thread (from SampleContext). We have to pass the isolate pointer. TBR=mikhail.naganov@gmail.com Committed: http://code.google.com/p/v8/source/detail?r=7485

Patch Set 1 #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -34 lines)			Patch
M	src/frames.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/frames.cc	View	6 chunks	+10 lines, -27 lines	0 comments	Download
M	src/isolate.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages