Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 6788015: bisect-builds.py: Use the continuous archive, rather than the snapshots. (Closed)

Created:
9 years, 8 months ago by Robert Sesek
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

bisect-builds.py: Use the continuous archive, rather than the snapshots. This will allow people to bisect back until 2008 on Windows and 2009 for Linux and Mac, rather than just the last ~1000 revisions. BUG=none TEST=bisect-builds.py works as before, but with a larger archive history Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83774

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments #

Patch Set 3 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -32 lines) Patch
M tools/bisect-builds.py View 1 2 10 chunks +66 lines, -32 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
9 years, 8 months ago (2011-04-01 17:01:17 UTC) #1
Evan Martin
LGTM http://codereview.chromium.org/6788015/diff/1/tools/bisect-builds.py File tools/bisect-builds.py (left): http://codereview.chromium.org/6788015/diff/1/tools/bisect-builds.py#oldcode86 tools/bisect-builds.py:86: fwiw, double-newline after function bodies is recommended python ...
9 years, 8 months ago (2011-04-14 19:03:56 UTC) #2
Robert Sesek
http://codereview.chromium.org/6788015/diff/1/tools/bisect-builds.py File tools/bisect-builds.py (left): http://codereview.chromium.org/6788015/diff/1/tools/bisect-builds.py#oldcode86 tools/bisect-builds.py:86: On 2011/04/14 19:03:56, Evan Martin wrote: > fwiw, double-newline ...
9 years, 7 months ago (2011-04-29 20:25:44 UTC) #3
Evan Martin
9 years, 7 months ago (2011-05-02 18:29:17 UTC) #4
LGTM

http://codereview.chromium.org/6788015/diff/4002/tools/bisect-builds.py
File tools/bisect-builds.py (right):

http://codereview.chromium.org/6788015/diff/4002/tools/bisect-builds.py#newco...
tools/bisect-builds.py:26: # can be obtained through ParseIndexLine().
Might be more maintainable to use something like
  /%(date)s/%(revision)d/

shrug

http://codereview.chromium.org/6788015/diff/4002/tools/bisect-builds.py#newco...
tools/bisect-builds.py:228: # 'linux-chromiumos' lacks a continuous archive
http://crbug.com/78158
80 cols

Powered by Google App Engine
This is Rietveld 408576698