Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: chrome/browser/ui/views/infobars/infobar_container_view.h

Issue 6788014: Fix DCHECK() in infobar animation. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/infobars/infobar_container_view.h
===================================================================
--- chrome/browser/ui/views/infobars/infobar_container_view.h (revision 80169)
+++ chrome/browser/ui/views/infobars/infobar_container_view.h (working copy)
@@ -16,10 +16,7 @@
explicit InfoBarContainerView(Delegate* delegate);
virtual ~InfoBarContainerView();
- // Overlap the previous view by this amount, vertically, so that the
- // first InfoBarView in this InfoBarContainer may draw its tab on
- // top.
- int VerticalOverlap();
+ virtual int GetVerticalOverlap() OVERRIDE;
private:
// AccessiblePaneView:
@@ -31,9 +28,9 @@
virtual void PlatformSpecificAddInfoBar(InfoBar* infobar) OVERRIDE;
virtual void PlatformSpecificRemoveInfoBar(InfoBar* infobar) OVERRIDE;
- // Return the maximum vertical overlap of the InfoBarContainer's children,
- // and, when |total_height| is non-NULL, set the |*total_height| of the
- // InfoBarContainer.
+ // Return the amount by which to overlap the toolbar above, and, when
+ // |total_height| is non-NULL, set it to the height of the InfoBarContainer
+ // (including overlap).
int GetVerticalOverlap(int* total_height);
DISALLOW_COPY_AND_ASSIGN(InfoBarContainerView);
« no previous file with comments | « chrome/browser/ui/views/infobars/infobar_container.cc ('k') | chrome/browser/ui/views/infobars/infobar_container_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698