Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 6788007: Fix multi-isolate build: (Closed)

Created:
9 years, 8 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix multi-isolate build: o Make ia32 macro assembler work without an isolate and use it in the custom memcpy creation code. o Remove isolate-dependent code from the custom memcpy and modulo functions creation code. Committed: http://code.google.com/p/v8/source/detail?r=7482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -25 lines) Patch
M src/builtins.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 2 chunks +9 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-posix.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/platform-win32.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/stub-cache.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Vitaly Repeshko
9 years, 8 months ago (2011-04-01 14:23:22 UTC) #1
Mads Ager (chromium)
9 years, 8 months ago (2011-04-01 14:30:07 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698