Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1541)

Issue 6783030: Mark services in password-fail as PassPhrase Required (Closed)

Created:
9 years, 8 months ago by Paul Stewart
Modified:
9 years, 7 months ago
Reviewers:
Sam Leffler, stevenjb
CC:
chromium-os-reviews_chromium.org, sleffler+cc_chromium.org, Nathan Williams, Eric Shienbrood, Jason Glasgow, rochberg, rtc
Visibility:
Public.

Description

Mark services in password-fail as PassPhrase Required If the service is currently failed due to a PassPhrase error, return "True" for the PassPhrase Requred property. Use a cached copy of the previous value to properly gate sending signals. Also provide damping so spurious signals are not sent. BUG=chromium-os:10135 TEST=Manual -- observe list-services while replicating conditions of 10135 Change-Id: Ib999360dabf47c637f660b8744afb85c4d59ad5f Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b22ddeb

Patch Set 1 #

Patch Set 2 : Create a damped, cached variable #

Patch Set 3 : Trim back to the original CL change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/service.c View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Paul Stewart
Is this along the lines of what you wanted Steven? Sam, could you look over ...
9 years, 8 months ago (2011-03-31 19:32:45 UTC) #1
stevenjb
That looks right, thanks. LGTM.
9 years, 8 months ago (2011-04-06 02:11:58 UTC) #2
Paul Stewart
On 2011/04/06 02:11:58, Steven Bennetts wrote: > That looks right, thanks. LGTM. Unfortunately it's not ...
9 years, 8 months ago (2011-04-06 03:14:55 UTC) #3
Paul Stewart
PTAL. This version uses a cached value to gate changes as well as damping to ...
9 years, 8 months ago (2011-04-08 04:13:50 UTC) #4
Paul Stewart
...and after a flurry of discussion on the issue, we're right back to the original ...
9 years, 8 months ago (2011-04-08 17:53:57 UTC) #5
Sam Leffler
9 years, 8 months ago (2011-04-08 17:59:21 UTC) #6
LGTM (and thank you for all the back-and-fort)

Powered by Google App Engine
This is Rietveld 408576698