Issue 6783011: Reapply changelist r7436.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6783011: Reapply changelist r7436. (Closed)

Created:
9 years, 8 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Reapply changelist r7436. Remove test for existence of VM. Not all tests need the VM. Committed: http://code.google.com/p/v8/source/detail?r=7452

Patch Set 1 #

Total comments: 1

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+319 lines, -119 lines)			Patch
M	SConstruct	View	1 chunk	+1 line, -1 line	0 comments	Download
M	preparser/preparser-process.cc	View	2 chunks	+77 lines, -114 lines	0 comments	Download
A	test/preparser/empty.js	View	1 chunk	+28 lines, -0 lines	0 comments	Download
A	test/preparser/functions-only.js	View	1 chunk	+38 lines, -0 lines	0 comments	Download
A	test/preparser/non-alphanum.js	View	1 chunk	+34 lines, -0 lines	0 comments	Download
A	test/preparser/symbols-only.js	View	1 chunk	+49 lines, -0 lines	0 comments	Download
A	test/preparser/testcfg.py	View	1 chunk	+90 lines, -0 lines	0 comments	Download
M	tools/test.py	View	3 chunks	+2 lines, -4 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

http://codereview.chromium.org/6783011/diff/1/tools/test.py File tools/test.py (left): http://codereview.chromium.org/6783011/diff/1/tools/test.py#oldcode1414 tools/test.py:1414: continue Change from r7436. This fails if only testing ...

9 years, 8 months ago (2011-03-31 08:10:35 UTC) #2

LGTM

Expand Messages | Collapse Messages