Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1757)

Unified Diff: chrome/browser/printing/print_view_manager.cc

Issue 6783005: Print Preview: Set a print job's title and url correctly. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: tab helpers stay with friends Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/printing/print_view_manager.h ('k') | chrome/browser/ui/tab_contents/tab_contents_wrapper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_view_manager.cc
===================================================================
--- chrome/browser/printing/print_view_manager.cc (revision 80726)
+++ chrome/browser/printing/print_view_manager.cc (working copy)
@@ -9,7 +9,9 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/printing/print_job.h"
#include "chrome/browser/printing/print_job_manager.h"
+#include "chrome/browser/printing/print_preview_tab_controller.h"
#include "chrome/browser/printing/printer_query.h"
+#include "chrome/browser/ui/webui/print_preview_ui.h"
#include "chrome/common/print_messages.h"
#include "content/browser/renderer_host/render_view_host.h"
#include "content/browser/tab_contents/navigation_entry.h"
@@ -24,6 +26,17 @@
using base::TimeDelta;
+namespace {
+
+string16 GenerateRenderSourceName(TabContents* tab_contents) {
+ string16 name(tab_contents->GetTitle());
+ if (name.empty())
+ name = l10n_util::GetStringUTF16(IDS_DEFAULT_PRINT_DOCUMENT_TITLE);
+ return name;
+}
+
+} // namespace
+
namespace printing {
PrintViewManager::PrintViewManager(TabContents* tab_contents)
@@ -31,7 +44,8 @@
number_pages_(0),
waiting_to_print_(false),
printing_succeeded_(false),
- inside_inner_message_loop_(false) {
+ inside_inner_message_loop_(false),
+ is_title_overridden_(false) {
#if defined(OS_POSIX) && !defined(OS_MACOSX)
expecting_first_page_ = true;
#endif
@@ -59,19 +73,22 @@
}
}
+void PrintViewManager::OverrideTitle(TabContents* tab_contents) {
+ is_title_overridden_ = true;
+ overridden_title_ = GenerateRenderSourceName(tab_contents);
+}
+
string16 PrintViewManager::RenderSourceName() {
- string16 name(tab_contents()->GetTitle());
- if (name.empty())
- name = l10n_util::GetStringUTF16(IDS_DEFAULT_PRINT_DOCUMENT_TITLE);
- return name;
+ if (is_title_overridden_)
+ return overridden_title_;
+ return GenerateRenderSourceName(tab_contents());
}
GURL PrintViewManager::RenderSourceUrl() {
NavigationEntry* entry = tab_contents()->controller().GetActiveEntry();
if (entry)
return entry->virtual_url();
- else
- return GURL();
+ return GURL();
}
void PrintViewManager::OnDidGetPrintedPagesCount(int cookie, int number_pages) {
« no previous file with comments | « chrome/browser/printing/print_view_manager.h ('k') | chrome/browser/ui/tab_contents/tab_contents_wrapper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698