Print Preview: Set a print job's title and url correctly.

chrome/browser/ui/tab_contents/tab_contents_wrapper.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_
 #define CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_
 #pragma once
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
+#include "chrome/browser/printing/print_view_manager.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "content/browser/tab_contents/tab_contents_observer.h"
 #include "content/common/notification_registrar.h"
 
 namespace prerender {
 class PrerenderObserver;
 }
 
 namespace printing {
 class PrintPreviewMessageHandler;
-class PrintViewManager;
 }
 
 class AutocompleteHistoryManager;
 class AutofillManager;
 class DevToolsObserver;
 class Extension;
 class ExtensionTabHelper;
 class FileSelectObserver;
 class FindTabHelper;
 class NavigationController;
@@ skipping 68 matching lines @@
   }
 
   FindTabHelper* find_tab_helper() { return find_tab_helper_.get(); }
 
   PasswordManager* password_manager() { return password_manager_.get(); }
 
   SearchEngineTabHelper* search_engine_tab_helper() {
     return search_engine_tab_helper_.get();
   }
 
+  printing::PrintViewManager* print_view_manager() {
+    return print_view_manager_.get();
+  }
+
   // Overrides -----------------------------------------------------------------
 
   // TabContentsObserver overrides:
   virtual void DidNavigateMainFramePostCommit(
       const NavigationController::LoadCommittedDetails& details,
       const ViewHostMsg_FrameNavigate_Params& params) OVERRIDE;
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
 
   // NotificationObserver overrides:
   virtual void Observe(NotificationType type,
@@ skipping 23 matching lines @@
 
   // Registers and unregisters us for notifications.
   NotificationRegistrar registrar_;
 
   // Data for current page -----------------------------------------------------
 
   // Whether the current URL is starred.
   bool is_starred_;
 
   // Handles print job for this contents.
-  scoped_ptr<printing::PrintViewManager> printing_;
+  scoped_ptr<printing::PrintViewManager> print_view_manager_;

[Avi (use Gerrit), 2011/04/06 11:21:32]

If this is a Tab Helper, put it in the Tab Helper section below.

[Lei Zhang, 2011/04/07 00:53:20]

Done.

 
   // Handles Print Preview messages.
   scoped_ptr<printing::PrintPreviewMessageHandler> print_preview_;

[Avi (use Gerrit), 2011/04/06 11:21:32]

No. This is a class that just sits there per-tab and watches. This goes in the
"per-tab observers" section below. I missed when you put it here. Please move
it.

[Lei Zhang, 2011/04/07 00:53:20]

Done.

 
   // Tab Helpers ---------------------------------------------------------------
   // (These provide API for callers and have a getter function listed in the
   // "Tab Helpers" section in the member functions area, above.)
 
   scoped_ptr<AutocompleteHistoryManager> autocomplete_history_manager_;
 
   scoped_ptr<AutofillManager> autofill_manager_;
 
   scoped_ptr<ExtensionTabHelper> extension_tab_helper_;
@@ skipping 19 matching lines @@
 
   // The supporting objects need to outlive the TabContents dtor (as they may
   // be called upon during its execution). As a result, this must come last
   // in the list.
   scoped_ptr<TabContents> tab_contents_;
 
   DISALLOW_COPY_AND_ASSIGN(TabContentsWrapper);
 };
 
 #endif  // CHROME_BROWSER_UI_TAB_CONTENTS_TAB_CONTENTS_WRAPPER_H_