Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2089)

Unified Diff: chrome/browser/net/websocket_experiment/websocket_experiment_task.cc

Issue 6780035: Use lock-free lazy initialization for static histogram references (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/url_info.cc ('k') | chrome/browser/sessions/session_restore.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/websocket_experiment/websocket_experiment_task.cc
===================================================================
--- chrome/browser/net/websocket_experiment/websocket_experiment_task.cc (revision 80382)
+++ chrome/browser/net/websocket_experiment/websocket_experiment_task.cc (working copy)
@@ -173,7 +173,6 @@
Histogram* counter = LinearHistogram::FactoryGet(
counter_name, 1, boundary_value, boundary_value + 1,
Histogram::kUmaTargetedHistogramFlag);
- counter->AddRef(); // Released in ReleaseHistogram().
g_histogram_table->insert(std::make_pair(counter_name, counter));
return counter;
}
@@ -194,7 +193,6 @@
Histogram* counter = Histogram::FactoryTimeGet(
counter_name, min, max, bucket_count,
Histogram::kUmaTargetedHistogramFlag);
- counter->AddRef(); // Released in ReleaseHistogram().
g_histogram_table->insert(std::make_pair(counter_name, counter));
return counter;
}
@@ -223,15 +221,6 @@
/* static */
void WebSocketExperimentTask::ReleaseHistogram() {
DCHECK(g_histogram_table);
- for (base::hash_map<std::string, Histogram*>::iterator iter =
- g_histogram_table->begin();
- iter != g_histogram_table->end();
- ++iter) {
- Histogram* counter = iter->second;
- if (counter != NULL)
- counter->Release();
- iter->second = NULL;
- }
delete g_histogram_table;
g_histogram_table = NULL;
}
« no previous file with comments | « chrome/browser/net/url_info.cc ('k') | chrome/browser/sessions/session_restore.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698