Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: net/base/connection_type_histograms.cc

Issue 6780035: Use lock-free lazy initialization for static histogram references (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/connection_type_histograms.cc
===================================================================
--- net/base/connection_type_histograms.cc (revision 79771)
+++ net/base/connection_type_histograms.cc (working copy)
@@ -21,13 +21,9 @@
// Each histogram has an unused bucket at the end to allow seamless future
// expansion.
void UpdateConnectionTypeHistograms(ConnectionType type) {
- // TODO(wtc): Bug 74467 Move these stats up to a higher level, where the
- // explicit static (shown below) and the implicit statics (inside the
- // HISTOGRAM macros) will be thread safe.
-#if 0 // Don't do anything for now.
+ // TODO(wtc): Bug 74467 Move these stats up to a higher level.
+ static bool had_connection_type[NUM_OF_CONNECTION_TYPES]; // Default false.
- static bool had_connection_type[NUM_OF_CONNECTION_TYPES];
-
if (type >= 0 && type < NUM_OF_CONNECTION_TYPES) {
if (!had_connection_type[type]) {
had_connection_type[type] = true;
@@ -40,7 +36,6 @@
} else {
NOTREACHED(); // Someone's logging an invalid type!
}
-#endif // 0
}
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698