Use lock-free lazy initialization for static histogram references

tools/valgrind/memcheck/suppressions.txt

 # There are three kinds of suppressions in this file.
 # 1. third party stuff we have no control over
 #
 # 2. intentional unit test errors, or stuff that is somehow a false positive
 # in our own code, or stuff that is so trivial it's not worth fixing
 #
 # 3. Suppressions for real chromium bugs that are not yet fixed.
 # These should all be in chromium's bug tracking system (but a few aren't yet).
 # Periodically we should sweep this file and the bug tracker clean by
 # running overnight and removing outdated bugs/suppressions.
@@ skipping 859 matching lines @@
    ...
    fun:_ZN4base13OpenTestNSSDBERK8FilePathPKc
 }
 {
    bug_61585c
    Memcheck:Leak
    fun:malloc
    fun:PL_ArenaAllocate
    fun:PORT_ArenaAlloc_Util
 }
+{
+   # Histograms are used on un-joined threads, and can't be deleted atexit.
+   HistogramsViaFactoryGetIncludingStatsLinearCustomBooleanAndBasic
+   Memcheck:Leak
+   fun:_Znw*
+   fun:_ZN4base*Histogram10FactoryGet*
+}
+{
+   # Histograms are used on un-joined threads, and can't be deleted atexit.
+   HistogramsViaFactoryGetIncludingStatsLinearCustomBooleanAndBasic
+   Memcheck:Leak
+   fun:_Znw*
+   fun:_ZN10disk_cache14StatsHistogram24StatsHistogramFactoryGet*
+}
 
 #-----------------------------------------------------------------------
 # 3. Suppressions for real chromium bugs that are not yet fixed.
 # These should all be in chromium's bug tracking system (but a few aren't yet).
 
 {
    # Chromium flakily leaks tasks at shutdown, see
    # http://crbug.com/6532
    # http://codereview.chromium.org/20067
    # http://codereview.chromium.org/42083
@@ skipping 3209 matching lines @@
    fun:calloc
    fun:g_malloc0
    fun:gtk_file_chooser_default_update_current_folder
    ...
    fun:_gtk_file_chooser_set_current_folder_path
    fun:gtk_file_chooser_set_current_folder
    fun:_ZN20SelectFileDialogImpl18CreateSaveAsDialogERKSsRK8FilePathP10_GtkWindow
    fun:_ZN20SelectFileDialogImpl10SelectFileEN16SelectFileDialog4TypeERKSbItN4base20string16_char_traitsESaItEERK8FilePathPKNS0_12FileTypeInfoEiRKSsP10_GtkWindowPv
    fun:_ZN15DownloadManager24OnPathExistenceAvailableEP18DownloadCreateInfo
    fun:_Z16DispatchToMethodI15DownloadManagerMS0_FvP18DownloadCreateInfoES2_EvPT_T0_RK6Tuple1IT1_E
-   fun:_ZN14RunnableMethodI15DownloadManagerMS0_FvP18DownloadCreateInfoE6Tuple1IS2_EE3RunEv
+   fun:_ZN14RunnableMethodI15DownloadManagerMS0_FvP18DownloadCreateInfoE6Tuple1vIS2_EE3RunEv

[rvargas (doing something else), 2011/04/04 19:24:55]

?

[jar (doing other things), 2011/04/04 22:13:09]

Spurious character removed.

THANKS for spotting this!!!!

 }
 {
    bug_77376_b
    Memcheck:Leak
    fun:malloc
    fun:dbus_malloc
    ...
    fun:dbus_g_bus_get
    fun:tracker_connect
    fun:_gtk_search_engine_tracker_new
@@ skipping 113 matching lines @@
 }
 {
    bug_todo_getdelim
    Memcheck:Leak
    fun:malloc
    fun:getdelim
    ...
    fun:call_init
    fun:_dl_init
 }