Issue 6780032: Minor cleanup in StaticMarkingVisitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6780032: Minor cleanup in StaticMarkingVisitor. (Closed)

Created:
9 years, 8 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Minor cleanup in StaticMarkingVisitor. Committed: http://code.google.com/p/v8/source/detail?r=7470

Patch Set 1 #

Total comments: 1

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -9 lines)			Patch
	M	src/mark-compact.cc	View		4 chunks	+13 lines, -9 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

9 years, 8 months ago (2011-03-31 19:23:16 UTC) #2

LGTM.

http://codereview.chromium.org/6780032/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

http://codereview.chromium.org/6780032/diff/1/src/mark-compact.cc#newcode505
src/mark-compact.cc:505: ASSERT(obj->map()->heap()->Contains(obj));
It's safer to have Isolate::Current() in asserts like this one.

Expand Messages | Collapse Messages