Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3175)

Unified Diff: base/string_util_unittest.cc

Issue 678001: base: string_util.h -> utf_string_conversions.h fix. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/stats_table_unittest.cc ('k') | base/sys_string_conversions_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/string_util_unittest.cc
===================================================================
--- base/string_util_unittest.cc (revision 40871)
+++ base/string_util_unittest.cc (working copy)
@@ -10,6 +10,7 @@
#include "base/basictypes.h"
#include "base/string_util.h"
+#include "base/utf_string_conversions.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace base {
@@ -30,7 +31,7 @@
#elif defined(WCHAR_T_IS_UTF32)
string16 u16;
while (*s != 0) {
- DCHECK(static_cast<unsigned int>(*s) <= 0xFFFFu);
+ DCHECK_LE(static_cast<unsigned int>(*s), 0xFFFFu);
u16.push_back(*s++);
}
return u16;
@@ -455,7 +456,7 @@
const char* uexpected;
};
-}
+} // namespace
TEST(StringUtilTest, IntToString) {
static const IntToStringTest<int> int_tests[] = {
@@ -1491,4 +1492,4 @@
EXPECT_FALSE(ContainsOnlyChars("123a", "4321"));
}
-} // namaspace base
+} // base
« no previous file with comments | « base/stats_table_unittest.cc ('k') | base/sys_string_conversions_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698