Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 6780008: Refactor crossystem to move x86-specific implementation to its own file. (Closed)

Created:
9 years, 8 months ago by Randall Spangler
Modified:
9 years, 7 months ago
Reviewers:
Olof Johansson
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson, Che-Liang Chiou, Tom Wai-Hong Tam, rongchang, robotboy
Visibility:
Public.

Description

Refactor crossystem to move x86-specific implementation to its own file. This should be ready for the ARM team to pick up and work on. I added a placeholder ARM implementation file, though it's not hooked up in the Makefile yet. As soon as you implement the VbNvStorage APIs, all the related crossystem commands will start working. Ditto for VbSharedData. The params which x86 gets from ACPI you'll need to get from u-boot somehow, probably via your own kernel driver. R=robotboy@chromium.org BUG=chromium-os:12522 TEST=emerge-x86-alex vboot_reference, make sure it still works on x86 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=eb59195

Patch Set 1 #

Patch Set 2 : Add default values for ARM (developer switch=1, etc) #

Patch Set 3 : Rename x86 arch dir #

Patch Set 4 : post-pull #

Unified diffs Side-by-side diffs Delta from patch set Stats (+893 lines, -604 lines) Patch
M host/Makefile View 1 1 chunk +2 lines, -0 lines 0 comments Download
A host/arch/arm/lib/crossystem_arch.c View 1 1 chunk +106 lines, -0 lines 0 comments Download
A host/arch/x86/lib/crossystem_arch.c View 2 1 chunk +591 lines, -0 lines 0 comments Download
A host/include/crossystem_arch.h View 1 chunk +80 lines, -0 lines 0 comments Download
M host/include/host_misc.h View 2 chunks +19 lines, -0 lines 0 comments Download
M host/lib/crossystem.c View 14 chunks +48 lines, -604 lines 0 comments Download
M host/lib/host_misc.c View 3 chunks +47 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Randall Spangler
9 years, 8 months ago (2011-03-30 23:14:13 UTC) #1
robotboy
Rong is a better person for this review since he will be working with the ...
9 years, 8 months ago (2011-03-30 23:20:56 UTC) #2
Randall Spangler
Can someone, anyone, look at this review, and at least determine it does no harm ...
9 years, 8 months ago (2011-04-04 16:38:53 UTC) #3
rongchang
Sorry for the late. I was trying to implement the kernel driver part that can ...
9 years, 8 months ago (2011-04-04 17:45:15 UTC) #4
Randall Spangler
9 years, 8 months ago (2011-04-04 22:59:30 UTC) #5
Olof Johansson
Rong, I think this is a step in the right direction even if the kernel ...
9 years, 8 months ago (2011-04-04 23:12:47 UTC) #6
Olof Johansson
9 years, 8 months ago (2011-04-07 02:48:52 UTC) #7
LGTM, let's get this in for now and we can improve later.

Powered by Google App Engine
This is Rietveld 408576698