Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 6778027: Add RunUnitTests() and RunUnitTestsInDirectory() canned checks. (Closed)

Created:
9 years, 8 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Add RunUnitTests() and RunUnitTestsInDirectory() canned checks. Deprecate RunPythonUnitTests() since it is a bit awkward. Add os_listdir, os_walk and platform to InputApi. GOAL=Slowly adds python 2.5 support for unit tests BUG=none TEST=new unit test R=dpranke@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80009

Patch Set 1 #

Total comments: 3

Patch Set 2 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -7 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M presubmit_canned_checks.py View 1 2 chunks +69 lines, -2 lines 0 comments Download
M presubmit_support.py View 2 chunks +3 lines, -1 line 0 comments Download
M tests/presubmit_unittest.py View 7 chunks +63 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
9 years, 8 months ago (2011-03-30 19:49:43 UTC) #1
Dirk Pranke
http://codereview.chromium.org/6778027/diff/1/presubmit_canned_checks.py File presubmit_canned_checks.py (right): http://codereview.chromium.org/6778027/diff/1/presubmit_canned_checks.py#newcode444 presubmit_canned_checks.py:444: sys.executable. I read "it" here as Windows (or Python), ...
9 years, 8 months ago (2011-03-30 20:18:58 UTC) #2
M-A Ruel
http://codereview.chromium.org/6778027/diff/1/presubmit_canned_checks.py File presubmit_canned_checks.py (right): http://codereview.chromium.org/6778027/diff/1/presubmit_canned_checks.py#newcode484 presubmit_canned_checks.py:484: """ On 2011/03/30 20:18:58, Dirk Pranke wrote: > Can ...
9 years, 8 months ago (2011-03-31 00:11:06 UTC) #3
Dirk Pranke
9 years, 8 months ago (2011-03-31 00:49:33 UTC) #4
Whoops, you're right. They are quite different.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698