src/ia32/full-codegen-ia32.cc - Issue 6778018: Only pass isolate parameter to C helper functions that need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 6778018: Only pass isolate parameter to C helper functions that need it. (Closed)

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index 16c39c5edb7d74d74db43ad374bbb54c0c999436..fb87a3fd538f987aa9410aca645b43b180582b4c 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -2717,9 +2717,10 @@ void FullCodeGenerator::EmitRandomHeapNumber(ZoneList<Expression*>* args) {

__ bind(&heapnumber_allocated);

- __ PrepareCallCFunction(0, ebx);

+ __ PrepareCallCFunction(1, ebx);

+ __ mov(Operand(esp, 0), Immediate(ExternalReference::isolate_address()));

__ CallCFunction(ExternalReference::random_uint32_function(isolate()),

- 0);

+ 1);

// Convert 32 random bits in eax to 0.(32 random bits) in a double

// by computing:

« no previous file with comments | « src/ia32/deoptimizer-ia32.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »