gooftool - Issue 6778007: gooftool: always process EC before BIOS (workaround for buggy EC)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gooftool

Issue 6778007: gooftool: always process EC before BIOS (workaround for buggy EC) (Closed) Base URL: ssh://gitrw.chromium.org:9222/factory_test_tools.git@master

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gooftool

diff --git a/gooftool b/gooftool

index 32f9c943b92a79cf24cd4cfc2dc5b8fe216c757c..a76aace04d2259913706687d3f5807d898f96f31 100755

--- a/gooftool

+++ b/gooftool

@@ -312,7 +312,7 @@ def wpfw():

if g_options.debug_dryrun_wpfw:

ErrorMsg('wpfw is by-passed. This device CANNOT be qualified.')

return True

- if EnableWriteProtect('bios') and EnableWriteProtect('ec'):

+ if EnableWriteProtect('ec') and EnableWriteProtect('bios'):

Louis 2011/03/30 09:28:59 hm... a risk here: if EnableWriteProtect('ec') is

Hung-Te 2011/03/30 09:40:09 That's what we want - if EnableWriteProtect ec fal

Nick Sanders 2011/03/30 09:40:43 Probably just as well to not writeprotect the rest

return True

ErrorDie('wpfw: failed to enable firmware write protection.')

@@ -424,7 +424,7 @@ def ConsoleParser():

help='prepare for wiping factory tests and '

'transit to release mode in next reboot')

parser.add_option('--verify', action='store_true',

- help='runs: --verify_switch-wp, --verify_switch_dev, '

+ help='runs: --verify_switch_wp, --verify_switch_dev, '

'--verify_hwid, --verify_keys')

parser.add_option('--finalize', action='store_true',

help='runs: --verify, --wpfw, '

« no previous file with comments | « gft_report.py ('k') | no next file » | no next file with comments »