Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 6777012: Fix chromeos-common.sh: false -> ${FLAGS_FALSE} (Closed)

Created:
9 years, 8 months ago by Luigi Semenzato
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Fix chromeos-common.sh: false -> ${FLAGS_FALSE} Change-Id: Ic1b0765470dcba081109adf7a34318fb4a4ac7c8 BUG=none TEST=none Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f0e18ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chromeos-common.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Luigi Semenzato
This is the fix for hungte's broken build problem. I am at home and cannot ...
9 years, 8 months ago (2011-03-30 14:17:27 UTC) #1
Hung-Te
On 2011/03/30 14:17:27, Luigi Semenzato wrote: > This is the fix for hungte's broken build ...
9 years, 8 months ago (2011-03-30 14:48:55 UTC) #2
Luigi Semenzato
Can you suggest how to test it? At what point of the build was it ...
9 years, 8 months ago (2011-03-30 15:15:38 UTC) #3
Hung-Te
On 2011/03/30 15:15:38, Luigi Semenzato wrote: > Can you suggest how to test it? At ...
9 years, 8 months ago (2011-03-30 17:11:44 UTC) #4
Hung-Te
The url seems to be truncated... Please merge the above two lines into one url: ...
9 years, 8 months ago (2011-03-30 17:12:57 UTC) #5
Luigi Semenzato
9 years, 8 months ago (2011-03-30 18:23:08 UTC) #6
Thank you.  Tested and pushed.

On Wed, Mar 30, 2011 at 10:12 AM, <hungte@chromium.org> wrote:

> The url seems to be truncated...
> Please merge the above two lines into one url:
>
>
> http://build.chromium.org/p/chromiumos/builders/
> x86%20generic%20full/builds/2287/steps/cbuildbot/logs/stdio
>
> http://codereview.chromium.org/6777012/
>

Powered by Google App Engine
This is Rietveld 408576698