Issue 6777011: Specialize ScavengingVisitor for the case when all logging and profiling is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6777011: Specialize ScavengingVisitor for the case when all logging and profiling is disabled. (Closed)

Created:
9 years, 8 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Specialize ScavengingVisitor for the case when all logging and profiling is disabled. By default use specialized static visitor and fallback to more generic one when one of the isolates with enabled logging/profiling hits GC. Committed: http://code.google.com/p/v8/source/detail?r=7443

Patch Set 1 #

Patch Set 2 : fix data race #

Patch Set 3 : use AtomicWord in VisitorDispatchTable instead of Callback #

Total comments: 4

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -30 lines)			Patch
M	src/heap.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/heap.cc	View	1	9 chunks	+90 lines, -27 lines	4 comments	Download
M	src/objects-visiting.h	View	1 2	2 chunks	+12 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

9 years, 8 months ago (2011-03-30 15:11:04 UTC) #2

LGTM!

http://codereview.chromium.org/6777011/diff/3001/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/6777011/diff/3001/src/heap.cc#newcode1252
src/heap.cc:1252: static inline void DoScavengeObject(Map* map,
This probably needs INLINE to prevent surprises with gcc.

http://codereview.chromium.org/6777011/diff/3001/src/heap.cc#newcode1531
src/heap.cc:1531: // However this does not lead any bugs as such isolate does
not have
"lead to"

http://codereview.chromium.org/6777011/diff/3001/src/heap.cc#newcode1533
src/heap.cc:1533: // to see table it in the consistent state.
"table it" -> "the table"

http://codereview.chromium.org/6777011/diff/3001/src/heap.cc#newcode4823
src/heap.cc:4823: initialized_gc = true;
nit: Is indentation off here?

Expand Messages | Collapse Messages